Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header disappears on small screens - Closes #459 #486

Merged
merged 4 commits into from
Feb 28, 2018
Merged

Header disappears on small screens - Closes #459 #486

merged 4 commits into from
Feb 28, 2018

Conversation

yasharAyari
Copy link
Contributor

What was the problem?

Header disappeared on screens shorter (in height) than 680px.

How did I fix it?

How to test it?

Test it on screens width the height shorter than 680px

Review checklist

@yasharAyari yasharAyari self-assigned this Feb 27, 2018
slaweet
slaweet approved these changes Feb 28, 2018
View reviewed changes
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, Yashar

@yasharAyari yasharAyari merged commit e1b0adf into 0.2.0 Feb 28, 2018
@yasharAyari yasharAyari deleted the 459-header-disappears-on-small-screens branch February 28, 2018 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaweet slaweet slaweet approved these changes

@reyraa reyraa Awaiting requested review from reyraa

Assignees

@yasharAyari yasharAyari

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yasharAyari @slaweet