Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage of electron wrapper - Closes #473 #483

Merged
merged 4 commits into from
Feb 27, 2018

Conversation

ginacontrino
Copy link
Contributor

@ginacontrino ginacontrino commented Feb 26, 2018

What was the problem?

Some electron related tests were not completely covered yet

How did I fix it?

Improved the test coverage of the files mentioned in #473

Review checklist

@ginacontrino ginacontrino force-pushed the 473-electron-wrapper-coverage branch from 46326b0 to de40b41 Compare February 26, 2018 17:05
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ginacontrino ginacontrino merged commit a1e2a7c into 0.2.0 Feb 27, 2018
@ginacontrino ginacontrino deleted the 473-electron-wrapper-coverage branch February 27, 2018 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants