Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test coverage of send transactions with HW wallet - Closes #1515 #1544

Merged
merged 13 commits into from
Dec 14, 2018

Conversation

michaeltomasik
Copy link
Contributor

@michaeltomasik michaeltomasik commented Dec 6, 2018

What issue have I solved?

-- #1515

How have I implemented/fixed it?

Fixed test coverage for files listed below:

  • src/components/resultBox/resultBox.js
  • src/components/send/steps/confirm/confirm.js
  • src/actions/peers.js

How has this been tested?

Check test coverage

Review checklist

src/actions/peers.test.js Outdated Show resolved Hide resolved
src/components/resultBox/resultBox.js Show resolved Hide resolved
src/components/send/steps/confirm/confirm.test.js Outdated Show resolved Hide resolved
src/components/send/steps/confirm/confirm.test.js Outdated Show resolved Hide resolved
src/components/resultBox/resultBox.test.js Show resolved Hide resolved
@slaweet slaweet changed the title Fix test send transactions with hw wallet - Closes #1515 Fix test coverage of send transactions with HW wallet - Closes #1515 Dec 7, 2018
slaweet
slaweet previously approved these changes Dec 7, 2018
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Mike 👍

@michaeltomasik michaeltomasik merged commit 22492a7 into 1.8.0 Dec 14, 2018
@michaeltomasik michaeltomasik deleted the 1515-fix-test-send-transactions-with-hwWallet branch December 14, 2018 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants