Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Node.js 8 - Closes #1532 #1533

Merged
merged 4 commits into from
Dec 3, 2018
Merged

Use Node.js 8 - Closes #1532 #1533

merged 4 commits into from
Dec 3, 2018

Conversation

fchavant
Copy link
Contributor

@fchavant fchavant commented Dec 3, 2018

What issue have I solved?

#1532

How have I implemented/fixed it?

  • bumped Node.js version to "8.14.0" in .nvmrc
  • modify Jenkinsfile to use nvm(getNodejsVersion()) blocks
  • switch from npm install to npm ci.

How has this been tested?

On Jenkins.

Review checklist

@fchavant fchavant self-assigned this Dec 3, 2018
@fchavant fchavant requested a review from slaweet December 3, 2018 10:05
slaweet
slaweet approved these changes Dec 3, 2018
View reviewed changes
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fchavant

@fchavant fchavant merged commit fc95c2d into development Dec 3, 2018
@fchavant fchavant deleted the 1532-use-node.js-8 branch December 3, 2018 10:31
@Matthelonianxl Matthelonianxl mentioned this pull request Feb 18, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaweet slaweet slaweet approved these changes

Assignees

@fchavant fchavant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fchavant @slaweet @francoilol