Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jenkins build by disabling minification - Mitigates #1439 #1450

Merged
merged 3 commits into from
Nov 6, 2018

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented Nov 6, 2018

What issue have I solved?

-- Mitigates #1439

How have I implemented/fixed it?

I disabled the minification and allowed bundles to be bigger

How has this been tested?

See Jenkins build to pass

Review checklist

@slaweet slaweet changed the title Fix Jenkins build by allowing npm run build to fail - Mitigates #1439 Fix Jenkins build by disabling minification - Mitigates #1439 Nov 6, 2018
michaeltomasik
michaeltomasik previously approved these changes Nov 6, 2018
Copy link
Contributor

@michaeltomasik michaeltomasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@michaeltomasik michaeltomasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@slaweet slaweet merged commit d0879cb into 1.6.0 Nov 6, 2018
@slaweet slaweet deleted the 1439-fix-failing-jenkins-build branch November 6, 2018 14:49
@slaweet slaweet mentioned this pull request Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants