Move send component steps into one folder - Closes#1419 #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r with new names form and confirm, all paths and imports are fix
|
Thanks for opening this pull request! Please check out our contributing guidelines. |
slaweet
approved these changes
Nov 6, 2018
|
Congrats on merging your first pull request! Ready for new challenges? You can find your next issue here |
osvaldovega
deleted the
1419-move-send-components-steps-into-one-folder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The send components are split in 3 folders, send, sendWritable and sendReadable. The main problem is that cause confusion because sendWritable and sendReadable are part of the send component, what made send component the root component.
The Send components are in three folders:
https://github.com/LiskHQ/lisk-hub/tree/v1.5.0/src/components/send
https://github.com/LiskHQ/lisk-hub/tree/v1.5.0/src/components/sendWritable
https://github.com/LiskHQ/lisk-hub/tree/v1.5.0/src/components/sendReadable
The other thing is that sendWritable and sendReadable components don't have names that represent the relation with the send root component so this change to Form and Confirm
What issue have I solved?
-- #1419
How have I implemented/fixed it?
The sendWritable and sendReadable components folder where remove from src/components and move to src/components/send/steps folder and change the name from sendWritable to Form and sendReadable to Confirm.
The paths and imports in the rest of files were update to avoid problems after the renaming.
How has this been tested?
Run the Lisk-Hub app locally and see that everything works as should be, in the other hand run the commands.
and
To confirm that all test all still working and nothing breaks after that.
Review checklist