Set max amount - Closes #1234 #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaweet
suggested changes
Oct 23, 2018
There was a problem hiding this comment.
- "Set max. amount" shouldn't be inside the
Convertercomponent, because that one is used not just in "Send" but also in "Request". "Set Max Amount" can be directly in the "SendWrtitable" - "Set max. amount" should have more bottom margin
- "Set max. amount" should not be displayed if the amount input is not focused (as described in the issue).
| wrapper.find('.set-max-amount').simulate('click'); | ||
| /* eslint-disable no-unused-expressions */ | ||
| expect(props.onSetMaxAmount).to.have.been.calledOnce; | ||
| /* eslint-enable no-unused-expressions */ |
There was a problem hiding this comment.
You can use just one comment before the statement
// eslint-disable-next no-unused-expressions
instead of one comment before and one after
|
merge conflict... |
Efefefef
suggested changes
Oct 29, 2018
slaweet
previously approved these changes
Oct 30, 2018
Efefefef
suggested changes
Oct 30, 2018
slaweet
approved these changes
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue have I solved?
-- #1234
How have I implemented/fixed it?
Add a link (behaves like a button) that sets the input to max amount minus the transaction fee
How has this been tested?
Review checklist