Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement disabled or not rendered button for passphrase confirm step #187

Closed
ginacontrino opened this issue Jan 10, 2018 · 0 comments
Closed

Comments

@ginacontrino
Copy link
Contributor

ginacontrino commented Jan 10, 2018

Expected behaviour

It should not be possible to go to the dashboard, without confirming your passphrase.
Also unskip the tests and make them work:
https://github.com/LiskHQ/lisk-wallet/blob/development/src/components/passphrase/confirm/index.test.js#L55

Actual behaviour

Currently, in the confirm step, the button 'get-to-your-dashboard-button' is not disabled when the missing words are incorrect or not filled in yet. Instead it is rendered with "display: none", which makes it possible to skip the step entirely and just move on to the dashboard, by displaying the button

Steps to reproduce

  • Start creating a new account
  • In the passphrase confirmation step, open the dev tools and display the button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants