Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip for multi-signature symbol #5363

Closed
punkrock opened this issue Oct 5, 2023 · 5 comments
Closed

Add tooltip for multi-signature symbol #5363

punkrock opened this issue Oct 5, 2023 · 5 comments

Comments

@punkrock
Copy link

punkrock commented Oct 5, 2023

Please add a tooltip for the two-keys-symbol.

image

Also consider the same for:

  • Hardware wallet icon
  • Validator icon
@ManuGowda
Copy link
Contributor

@punkrock I think adding tooltip icon defeats the purpose of icon? ideally the icon should give users an idea about what it is? we can also check if there is a better icon to use for multisig, not sure about tooltip though.

@ann-vashchenko @Ade-kola what do you guys think about this suggestion?

@punkrock
Copy link
Author

punkrock commented Oct 5, 2023

@ManuGowda You should not change the icon. You should add a tooltip (description) to it if a user hovers with the mouse that explains what the icon means.

@ann-vashchenko
Copy link

@ManuGowda It's a good point to add the tooltip here. We use tooltips for the icons at the top menu because they don't have labels, so the same should be done with the multisignature icon.

@Ade-kola
Copy link

Ade-kola commented Oct 6, 2023

@ManuGowda we can use the hover effect for the key like we use in showing public keys before. So when users hover on the key, we can show what it means.

@ManuGowda
Copy link
Contributor

Thanks for all the inputs @punkrock @ann-vashchenko @Ade-kola , then lets add necessary tooltips for all the icons 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

6 participants