Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect status shown for transactions and blocks #5010

Closed
ManuGowda opened this issue May 17, 2023 · 0 comments · Fixed by #5011
Closed

Incorrect status shown for transactions and blocks #5010

ManuGowda opened this issue May 17, 2023 · 0 comments · Fixed by #5011
Assignees
@ManuGowda
Labels
type: bug unplanned
Milestone
Sprint 100

Comments

@ManuGowda
Copy link
Contributor

Expected behavior

  • Remove confirmations from transaction status (we have finality status now)
  • Show valid block and transaction status returned by API

Actual behavior

  • Why are we showing the number of confirmations for the transaction status? Doesn't make any sense because we have the finality now.
  • The block status shows final whereas the API returns isFinal to be false.

image

image

image

Which version(s) does this affect? (Environment, OS, etc...)

3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ManuGowda ManuGowda

Labels
type: bug unplanned
Projects
No open projects
Lisk Desktop Version 3.0.0
Status: Done
Milestone
Sprint 100
Development

Successfully merging a pull request may close this issue.

Fix status and peer list rending issues LiskHQ/lisk-desktop
2 participants
@ManuGowda @sridharmeganathan