Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename usage of delegates, votes, unvotes #4721

Closed
Tracked by #4516
ManuGowda opened this issue Jan 13, 2023 · 0 comments
Closed
Tracked by #4516

Rename usage of delegates, votes, unvotes #4721

ManuGowda opened this issue Jan 13, 2023 · 0 comments

Comments

@ManuGowda
Copy link
Contributor

ManuGowda commented Jan 13, 2023

Description

As part of Update DPoS module epic we are migrating the terminology related dpos, in source code there any many occurrence of delegates, votes, unvotes, etc..

Acceptance Criteria

  • Rename all occurrence of delegates, votes, unvotes to validator, stake, unstake
  • Ensure the functionalities related to staking, unstaking, unlocking, validator registration are working as intended
  • This tasks should focus on just on renaming and if we see any major business logic changes required then we should create a separate issue before addressing

Additional Information

Following are some of the files that contain these legacy terminology

setup/react/app/mixins.css:
src/modules/pos/validator/components/SentStakesRow/SentStakesRow.css:
src/modules/pos/validator/components/StakeForm/stakeForm.css:
src/modules/pos/validator/components/ValidatorProfile/ValidatorProfile.css:
src/modules/transaction/components/TransactionRow/row.css:
src/modules/wallet/components/searchBarWallets/walletsAndDeletegates.css:
setup/react/assets/images/icons/account-removed.svg:
setup/react/assets/images/main-menu-icons/delegates.svg:
import welcomeLiskValidators from '@setup/react/assets/images/illustrations/illustration-welcome-to-lisk-delegates-dark.svg';
import yourVoiceMatters from '@setup/react/assets/images/illustrations/illustration-your-voice-matters-dark.svg';
import registerValidator from '@setup/react/assets/images/icons/tx-registerValidator.svg';
import registerValidatorDark from '@setup/react/assets/images/icons/tx-delegate-dark.svg';
import stake from '@setup/react/assets/images/icons/tx-stake.svg';
import transactionsMonitorActive from '@setup/react/assets/images/icons/transactionsMonitorActive.svg';
import validatorsMonitor from '@setup/react/assets/images/icons/delegatesMonitor.svg';
import validatorsMonitorActive from '@setup/react/assets/images/icons/delegatesMonitorActive.svg';
import networkMonitor from '@setup/react/assets/images/icons/networkMonitor.svg';
import upload from '@setup/react/assets/images/icons/upload.svg';
import validatorForged from '@setup/react/assets/images/icons/delegate-forged.svg';
import validatorForgedDark from '@setup/react/assets/images/icons/delegate-forged-dark.svg';
import validatorMissed from '@setup/react/assets/images/icons/delegate-missed.svg';
import validatorMissedDark from '@setup/react/assets/images/icons/delegate-missed-dark.svg';
import validatorWarning from '@setup/react/assets/images/icons/delegate-warning.svg';
import validatorAwaiting from '@setup/react/assets/images/icons/delegate-awaiting.svg';
import validatorAwaitingDark from '@setup/react/assets/images/icons/delegate-awaiting-dark.svg';
import validatorActive from '@setup/react/assets/images/icons/delegate-active.svg';
import validatorActiveDark from '@setup/react/assets/images/icons/delegate-active-dark.svg';
import validatorStandby from '@setup/react/assets/images/icons/delegate-standby.svg';
import validatorStandbyDark from '@setup/react/assets/images/icons/delegate-standby-dark.svg';
import validatorIneligible from '@setup/react/assets/images/icons/delegate-ineligible.svg';
import validatorIneligibleDark from '@setup/react/assets/images/icons/delegate-ineligible-dark.svg';
import validatorPunished from '@setup/react/assets/images/icons/delegate-punished.svg';
import validatorPunishedDark from '@setup/react/assets/images/icons/delegate-punished-dark.svg';
import validatorBanned from '@setup/react/assets/images/icons/delegate-banned.svg';
import validatorBannedDark from '@setup/react/assets/images/icons/delegate-banned-dark.svg';
import eyeInactive from '@setup/react/assets/images/icons/eye-inactive.svg';
src/modules/account/hooks/useDeprecatedAccount.js:
src/modules/pos/validator/api/index.js:
src/modules/pos/validator/components/LatestStakes/index.js:
src/modules/pos/validator/components/SentStakesRow/SentStakesRow.js:
src/modules/pos/validator/components/StakeForm/StakeRow.js:
src/modules/pos/validator/components/ValidatorPerformance/index.js:
src/modules/pos/validator/components/ValidatorPerformance/ValidatorPerformance.js:
src/modules/pos/validator/components/ValidatorPerformance/ValidatorPerformanceDetails.js:
src/modules/pos/validator/components/ValidatorsTable/DataColumns.js:
src/modules/pos/validator/hooks/queries/useValidators.js:
src/modules/pos/validator/store/actions/staking.js:
src/modules/pos/validator/store/actions/watchList.js:
src/modules/pos/validator/store/middlewares/watchList.js:
src/modules/search/components/SearchBar/SearchBar.js:
src/modules/token/fungible/components/BalanceInfo/index.js:
src/modules/transaction/api/index.js:
src/modules/transaction/components/StakeItem/StakeItem.js:
src/modules/transaction/components/TransactionDetails/sender.js:
src/modules/transaction/components/TransactionRow/components.js:
src/modules/transaction/components/TransactionRow/index.js:
src/modules/transaction/components/WalletTransactions/TransactionList.js:
src/modules/transaction/store/actions.js:
src/modules/transaction/utils/normalizeStakesForTx.js:
src/modules/wallet/components/searchBarWallets/validators.js:
src/modules/wallet/components/walletInfo/actionBar.js:
src/modules/wallet/components/walletInfo/identity.js:
src/theme/Icon/index.js:
src/utils/withData.js:
tests/constants/selectors.js:
tests/constants/stakes.js:
tests/constants/validators.js:
tests/dev_config_and_db/genesis_block.json:
tests/fixtures/delegates.js:
tests/fixtures/transactionsData.js:
tests/unit-test-utils/fakeStore.js:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

3 participants