Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not making a change to the custom derivation when creating an account give you an error #4616

Closed
Tracked by #4341
oskarleonard opened this issue Nov 30, 2022 · 3 comments

Comments

@oskarleonard
Copy link
Contributor

Expected behavior

When user adds a new account and make no change to the pre filled derivation path the default should be used.

Actual behavior

Making no change to the pre filled value will try to create the account with an undefined derivation path and lead to error
image

Steps to reproduce

  • Enable custom derivation path in settings
  • Add an account
  • Dont change custom derivation path
  • Try do continue adding the account
  • After trying to setup a password you will see the toast "Failed to setup password"

Which version(s) does this affect? (Environment, OS, etc...)

v3

@soroushm
Copy link
Contributor

@oskarleonard then why you think its about drivition path? if you turn off the custom drivition path is passing?

@oskarleonard
Copy link
Contributor Author

@oskarleonard then why you think its about drivition path? if you turn off the custom drivition path is passing?

Yes, works if i turn off derivation path. We are using two sources of truth for this and never initialize redux with the default value when setting it to true. Which means that
image
customDerivationPath will be undefined. And why it works for Manu in issue is because he is triggering the onChange here
image

So this issue is very related to this, and both need to be kept in mind when fixing this.

@soroushm
Copy link
Contributor

soroushm commented Nov 30, 2022

Similar issues #4591

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

4 participants