Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network params for application meta data #4504

Closed
Tracked by #4341
soroushm opened this issue Oct 10, 2022 · 0 comments
Closed
Tracked by #4341

Fix network params for application meta data #4504

soroushm opened this issue Oct 10, 2022 · 0 comments
Assignees
Milestone

Comments

@soroushm
Copy link
Contributor

soroushm commented Oct 10, 2022

Expected behavior

  • network query parameter should only be called for endpoints which require specific metadata
  • Once a network is chosen (mainnet, testnet or custom node URL) the rest of the domains (blocks, transactions, etc..) should query the URL without network
  • Only following endpoints should have network parameter
    • /api/v3/blockchain/apps/meta/list
    • /api/v3/blockchain/apps/meta
    • /api/v3/blockchain/apps/meta/tokens

Actual behavior

  • All the endpoints query parameter includes network field, which is not correct

Steps to reproduce

  • npm run dev
  • Access the wallet features, open network tab to observe the query parameter
@ManuGowda ManuGowda changed the title fix network params for application meta data Fix network params for application meta data Oct 10, 2022
Repository owner moved this from Backlog to Done in Lisk Desktop Version 3.0.0 Oct 10, 2022
@ManuGowda ManuGowda added this to the Sprint 84 milestone Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants