Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The accounts are not correctly listed in the HW sign-in screen tabs #3979

Closed
Tracked by #3963
reyraa opened this issue Nov 29, 2021 · 0 comments
Closed
Tracked by #3963

The accounts are not correctly listed in the HW sign-in screen tabs #3979

reyraa opened this issue Nov 29, 2021 · 0 comments

Comments

@reyraa
Copy link
Contributor

reyraa commented Nov 29, 2021

Description

We make API calls for each account discovered in the connected HW to gain more information then split them in 3 tabs: active, empty, reclaimable. We need to improve our computations by:

  • With publicKey and amount > 0 LSK ➜ Active
  • With publicKey but amount == 0 LSK ➜ empty account
  • No publicKey but legacy amount > 0 LSK ➜ reclaimable
  • No publicKey and amount == 0 LSK ➜ empty account (new)

Steps to reproduce

Use a ledger Nano S to sign in. Create accounts with the above configurations.

Additional information

I think in the discovery algorithm checks if there are some tx (that's exactly what I coded for legacy liskish wallet) and it makes bad assumption about the initialization of the account (edited)
I believe we just need to check if it has a pubKey

Which version(s) does this affect? (Environment, OS, etc...)

2.2.0-beta.0

@reyraa reyraa added this to the Sprint 63 milestone Nov 29, 2021
@sridharmeganathan sridharmeganathan removed this from the Sprint 63 milestone Dec 1, 2021
@sridharmeganathan sridharmeganathan added this to the Sprint 63 milestone Dec 2, 2021
@sridharmeganathan sridharmeganathan modified the milestones: Sprint 63, Sprint 64 Dec 8, 2021
@ManuGowda ManuGowda modified the milestones: Sprint 64, Spike 3 Dec 17, 2021
@ManuGowda ManuGowda modified the milestones: Spike 3, Sprint 65 Jan 1, 2022
@reyraa reyraa closed this as completed Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants