Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update percy config #3481

Closed
UsamaHameed opened this issue Apr 15, 2021 · 3 comments
Closed

Update percy config #3481

UsamaHameed opened this issue Apr 15, 2021 · 3 comments

Comments

@UsamaHameed
Copy link
Contributor

Expected behavior

Percy uses storybook which in turn uses webpack. Since we updated the configs for webpack and updated several build packages, we need to update the webpack config used for storybook as well and make sure percy runs correctly on jenkins.

Actual behavior

Percy fails due to a config error.

@ManuGowda ManuGowda modified the milestones: Sprint 65, Sprint 66 Jan 18, 2022
@sridharmeganathan sridharmeganathan removed this from the Sprint 66 milestone Feb 1, 2022
@sridharmeganathan
Copy link
Contributor

This will be addressed in Lisk Desktop Version 3.0.0

@sridharmeganathan
Copy link
Contributor

Moved to Epic #4033

@ManuGowda
Copy link
Contributor

We need to revisit our visual testing approach, the current infrastructure is outdated for longtime and continue to patch this will take longer time and it won't be a good direction. We will analyse and introduce the visual testing for future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants