Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use moduleAssets instead of transactionTypes #3290

Closed
reyraa opened this issue Jan 20, 2021 · 0 comments
Closed

Use moduleAssets instead of transactionTypes #3290

reyraa opened this issue Jan 20, 2021 · 0 comments

Comments

@reyraa
Copy link
Contributor

reyraa commented Jan 20, 2021

Description

According to Lisk Service documents, Lisk blockchain replaces transaction types with module id and assets ids. Lisk Service provides the list of available module-asset pairs through the network status endpoint.
Since we use transaction types throughout Lisk Desktop to display data correctly, we need to ensure the application works with moduleAssets seamlessly, by replacing transaction types with moduleAssets.
Since Lisk blockchain had 2 transaction types, legacy and new, Lisk Desktop introduced a new string property called transaction title to replace both types values of a transaction. We need to replace these values with the corresponding moduleAsset.

Changes include:

  • Remove all configs except the human readable sender titles in the transactionTypes.js.
  • Rename transactionTypes.js to moduleAssets.js.
  • Replace all instances of transactionTypes usage with moduleAssets from the Redux store.
  • Adapt unit tests.

Motivation

Support Lisk SDK v5

Acceptance Criteria

  • Unit tests should pass.
  • The application should work as it did before the new changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants