Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor votingListView components #1470

Closed
osvaldovega opened this issue Nov 7, 2018 · 1 comment · May be fixed by Matthelonianxl/lisk-hub#11 or Matthelonianxl/lisk-hub#12
Closed

Refactor votingListView components #1470

osvaldovega opened this issue Nov 7, 2018 · 1 comment · May be fixed by Matthelonianxl/lisk-hub#11 or Matthelonianxl/lisk-hub#12

Comments

@osvaldovega
Copy link
Contributor

Under src/votingListView folder there are several components but there are 4 in total, that looks like duplicated.

At this point, the component delegateList and voteList are components that display a list of data (delegates) and the only difference is that in the delegateList you can see an checkbox element where you can select (vote) and in the voteList you can see the same type of data but without the checkbox.

Both components use another component for render the list of delegates and those are delegateRow and voteRow, these elements are duplicated as their functions is the same wit a few differences as I already mentioned.

  • Check and review the data the both components display.

  • Normalize the data to display.

  • Remove delegateRow and voteRow and use one component for render the normalized data/

@slaweet
Copy link
Contributor

slaweet commented Feb 13, 2019

Cleaning up - Closing issues that were open for a long time without any update. We can re-open if needed. This should be solved when implementing the new delegates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants