Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration: Custom node reg always falls back on localhost:4000 #1326

Closed
Efefefef opened this issue Oct 8, 2018 · 1 comment
Closed

Registration: Custom node reg always falls back on localhost:4000 #1326

Efefefef opened this issue Oct 8, 2018 · 1 comment
Assignees

Comments

@Efefefef
Copy link
Contributor

Efefefef commented Oct 8, 2018

Steps to reproduce

  1. Run lisk core not on the 4000 port
  2. Choose Custom Node
  3. Enter Url on which you are running core
  4. Walk through the registration process

Actual result

Error popup: Unable to connect to node
Hub tries to connect to localhost:4000

Expected result

Appear logged in devnet on specified port

Version

1.3, 1.4

Screenshot (if appropriate)

@slaweet
Copy link
Contributor

slaweet commented Oct 29, 2018

Specification

  • Custom node URL should be validated (try to connect to it) on login page when clicking "Create Lisk ID"
  • If the request is successful, then set the node and go to the first step of creating a new account
  • If the request fails, then show "Unable to connect the node" error toast and stay on the login page
  • If network is not custom node, then clicking "Create Lisk ID" doesn't check the mainnet/testnet URL, sets the node, and goes directly to the first step of creating a new account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants