Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor TransactionsDetailView component #1282

Closed
slaweet opened this issue Sep 13, 2018 · 1 comment
Closed

Refactor TransactionsDetailView component #1282

slaweet opened this issue Sep 13, 2018 · 1 comment
Assignees
@bmaggi-lisk
Labels
type: refactoring

Comments

@slaweet
Copy link
Contributor

slaweet commented Sep 13, 2018

It is too big and there are some other issues described in #1273
@michaeltomasik
Copy link
Contributor

michaeltomasik commented Sep 13, 2018 •
edited
Loading

Suggested refactoring:
Refactor by setting const fields to display per transaction type in a separate file and then render it in 2 columns.

[{
    transactionType: TransacitionType.send,
    fields: [ 'date', 'recipient', 'senderId'],
}, {} ...]

@bmaggi-lisk bmaggi-lisk self-assigned this Oct 9, 2018
@slaweet slaweet added the *medium label Oct 9, 2018
@slaweet slaweet removed the *medium label Nov 1, 2018
@bmaggi-lisk bmaggi-lisk mentioned this issue Nov 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmaggi-lisk bmaggi-lisk

Labels
type: refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@slaweet @michaeltomasik @bmaggi-lisk