Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity: Delegate statistics: Delegates name is not shown instead of id #1035

Closed
Efefefef opened this issue Jul 13, 2018 · 3 comments
Closed

Comments

@Efefefef
Copy link
Contributor

Efefefef commented Jul 13, 2018

Steps to reproduce

  1. Go to the delegate's acc with votes from named account, (devnet: 17110047919889272525L)
  2. Open Delegate statistics in Activity
  3. Look at Who voted

Actual behaviour

Delegate's id
(devnet: 4401082358022424760L )

Expected behaviour

Delegate's name

child of #812

@slaweet slaweet self-assigned this Jul 13, 2018
@slaweet
Copy link
Contributor

slaweet commented Jul 13, 2018

Investigation results:
The problem is that in the 0.9.X API, the vote and voter objects contained username, but in 1.0.0 this field was removed.
So there is no easy way to display the delegate name. Next, I will look into non-easy ways.

@slaweet
Copy link
Contributor

slaweet commented Jul 31, 2018

So the best solution is to use lisk-explorer as a data source for this, but that involves a lot of extra changes. E.g. being able to set explorer node when setting a custom node, setting up our Jenkins to run explorer node etc. So it won't be done in 1.0.0

@slaweet
Copy link
Contributor

slaweet commented Feb 13, 2019

Cleaning up - Closing issues that were open for a long time without any update. We can re-open if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants