Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

When genesis height is not zero, maxRemovalHeight returns 0 #9044

Closed
shuse2 opened this issue Sep 27, 2023 · 0 comments
Closed

When genesis height is not zero, maxRemovalHeight returns 0 #9044

shuse2 opened this issue Sep 27, 2023 · 0 comments
Assignees
Milestone

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Sep 27, 2023

Expected behavior

When genesis height is not zero, maxRemovalHeight should return genesis height.

aggregateCommint.height should be set to the genesis height because block at genesis height + 1 will have aggregateCommint.height == genesis height .

Actual behavior

https://github.com/LiskHQ/lisk-sdk/blob/v6.0.0-rc.1-1/framework/src/engine/generator/generator.ts#L217-L219
when genesis height is non zero, and if maxRemovalHeight is 0, the range of certificate generation will be (0, genesisHeight].
Although there BFTParam doesn't exist so the certificate will not be generated, the loop will be too big that the node won't be able to start

Steps to reproduce

Start a testnet node which uses 6.0.0-rc.1 with validator enabled

Which version(s) does this affect? (Environment, OS, etc...)

6.0.0-rc.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant