Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Token methods lack checks for negative token amounts #8912

Closed
Tracked by #7226
shuse2 opened this issue Aug 30, 2023 · 0 comments · Fixed by #8918
Closed
Tracked by #7226

Token methods lack checks for negative token amounts #8912

shuse2 opened this issue Aug 30, 2023 · 0 comments · Fixed by #8918
Assignees
Milestone

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Aug 30, 2023

Description

Partially resolved in PR #8559. it resolved most instances of the problem, but the transferCrossChain function does validate its messageFee argument and the payMessageFee function does not validate its fee argument. Ideally, it would be great to use a new type that only supports unsigned bigints, but JavaScript does not support unsigned bigints by default.

Which version(s) does this affect? (Environment, OS, etc...)

6.0.0-beta.7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants