Skip to content
This repository was archived by the owner on Jun 11, 2024. It is now read-only.

Update forward method to handle ccm fee properly #8735

Closed
Tracked by #7226
ishantiw opened this issue Jul 13, 2023 · 1 comment
Closed
Tracked by #7226

Update forward method to handle ccm fee properly #8735

ishantiw opened this issue Jul 13, 2023 · 1 comment
Assignees
@sitetester
Labels
framework/module/interoperability Interoperability module type: bug
Milestone
Sprint 102

Comments

@ishantiw
Copy link
Contributor

ishantiw commented Jul 13, 2023 •
edited by sitetester
Loading

Description

Update forward method to handle CCM fee properly

  • Update interface for beforeCrossChainMessageForwarding to handle mdl.beforeCrossChainMessageForwarding(trs, ccm, ccmFailed) in the LIP, so simply create another context for forward extending CrossChainMessageContext
  • Improve code based on the refactoring in LIP PR Fix bounce issue lips#405

Related LIP https://github.com/LiskHQ/lips/blob/main/proposals/lip-0049.md

Which version(s) does this affect? (Environment, OS, etc...)

v6.0.0-beta.4
This was referenced Jul 4, 2023
Closed
Closed
@sitetester sitetester self-assigned this Jul 27, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 100, Sprint 101 Jul 31, 2023
@sitetester sitetester mentioned this issue Aug 7, 2023
Merged
@sitetester
Copy link
Contributor

New LIP version - LiskArchive/lips#449

@Madhulearn Madhulearn modified the milestones: Sprint 101, Sprint 102 Aug 14, 2023
@shuse2 shuse2 closed this as completed Aug 15, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Lisk SDK Version 6.0.0 Aug 15, 2023
@mitsuaki-u mitsuaki-u mentioned this issue Aug 15, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sitetester sitetester

Labels
framework/module/interoperability Interoperability module type: bug
Projects
None yet
Milestone
Sprint 102
Development

No branches or pull requests
4 participants
@sitetester @shuse2 @ishantiw @Madhulearn