Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Validate PoS params whose ranges are defined by block time #8694

Closed
Tracked by #7226
bobanm opened this issue Jul 6, 2023 · 0 comments
Closed
Tracked by #7226

Validate PoS params whose ranges are defined by block time #8694

bobanm opened this issue Jul 6, 2023 · 0 comments
Assignees
@bobanm
Labels
framework type: improvement
Milestone
Sprint 100

Comments

@bobanm
Copy link
Contributor

bobanm commented Jul 6, 2023

For config params from PoS module failSafeInactiveWindow and punishmentWindow, it would be good to perform range validation based on block time. Since block time is also a configured value and not a constant, it does not make sense to pass block time to schema.

Instead, the value range check for those 2 parameters could be implemented in PoSModule.init().

The range values should be the ones from defined in #8465.
@bobanm bobanm self-assigned this Jul 6, 2023
@bobanm bobanm mentioned this issue Jul 6, 2023
Closed
@bobanm bobanm changed the title PoS config params runtime validation Validate PoS params whose ranges are defined by block time Jul 7, 2023
@bobanm bobanm mentioned this issue Jul 10, 2023
Merged
@Madhulearn Madhulearn added this to the Sprint 99 milestone Jul 17, 2023
@Madhulearn Madhulearn mentioned this issue Jul 18, 2023
Closed
@Madhulearn Madhulearn modified the milestones: Sprint 99, Sprint 100 Jul 18, 2023
@shuse2 shuse2 closed this as completed Jul 25, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Lisk SDK Version 6.0.0 Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bobanm bobanm

Labels
framework type: improvement
Projects
None yet
Milestone
Sprint 100
Development

No branches or pull requests
3 participants
@shuse2 @bobanm @Madhulearn