Skip to content
This repository was archived by the owner on Jun 11, 2024. It is now read-only.

Missing check in getMessageFeeTokenID #8618

Closed
Tracked by #7226
ishantiw opened this issue Jun 16, 2023 · 0 comments · Fixed by #8687
Closed
Tracked by #7226

Missing check in getMessageFeeTokenID #8618

ishantiw opened this issue Jun 16, 2023 · 0 comments · Fixed by #8687
Assignees
@sitetester
Labels
framework/module/interoperability Interoperability module type: bug
Milestone
Sprint 99

Comments

@ishantiw
Copy link
Contributor

Description

The getMessageFeeTokenID method is missing the own chain check described in the LIP. This check is implemented in other functions such as getMinReturnFeePerByte. Calculation of the updatedChainID variable should be centralized in a single function to avoid these discrepancies.

Which version(s) does this affect? (Environment, OS, etc...)

v6.0.0-beta.2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sitetester sitetester

Labels
framework/module/interoperability Interoperability module type: bug
Projects
None yet
Milestone
Sprint 99
Development

Successfully merging a pull request may close this issue.

Simplify code for getMessageFeeTokenID & getMinReturnFeePerByte LiskArchive/lisk-sdk
3 participants
@sitetester @ishantiw @Madhulearn