You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Some minor improvements to Commit List sorting logic:
ascendingHeight is not an appropriate argument for the argument passed to CommitList.getAll(), where the argument defines sorting order.
Instead of having 2 different sort commands in CommitList.getAll() based on argument value, this could be reduced to 1 command with a smarter use of COMMIT_SORT constant values.
It's not needed to use sort order argument in CommitPool._getAllCommits(), as ascending is the default sort order of CommitList.getAll().
CommitList.deleteByHeight() has an unusual conditional, which checks for an element which was deleted on the very previous line, and then tries to delete it again [?!].
The text was updated successfully, but these errors were encountered:
Some minor improvements to Commit List sorting logic:
ascendingHeight
is not an appropriate argument for the argument passed toCommitList.getAll()
, where the argument defines sorting order.CommitList.getAll()
based on argument value, this could be reduced to 1 command with a smarter use ofCOMMIT_SORT
constant values.CommitPool._getAllCommits()
, as ascending is the default sort order ofCommitList.getAll()
.CommitList.deleteByHeight()
has an unusual conditional, which checks for an element which was deleted on the very previous line, and then tries to delete it again [?!].The text was updated successfully, but these errors were encountered: