Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Review of unit test for 'events' #8066

Closed
ricott1 opened this issue Jan 24, 2023 · 1 comment
Closed

Review of unit test for 'events' #8066

ricott1 opened this issue Jan 24, 2023 · 1 comment
Assignees
Milestone

Comments

@ricott1
Copy link
Contributor

ricott1 commented Jan 24, 2023

Review for: https://github.com/LiskHQ/lisk-sdk/blob/development/elements/lisk-chain/test/unit/event.spec.ts

@ricott1 ricott1 changed the title Review of unit test ofr 'events' Review of unit test for 'events' Jan 24, 2023
@Madhulearn Madhulearn added this to the Sprint 109 milestone Nov 21, 2023
@Madhulearn Madhulearn moved this to In Progress in Lisk SDK Version 6.1.0 Nov 23, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 109, Sprint 110 Dec 4, 2023
@mosmartin
Copy link
Contributor

@ricott1, @shuse2 the requirements/unit tests requested in this ticket cannot be tested as there is no implementation in the event file being tested. There is no function that checks for the event name nor is there a function that checks for event validity (like too many topics or too large data size). When I was going through the tests, I noticed there are no -ve tests so I added some.

@Madhulearn Madhulearn modified the milestones: Sprint 110, Sprint 111 Dec 18, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 111, Sprint 110 Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants