Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Network connectivity channels #347

Closed
ghost opened this issue Dec 9, 2016 · 2 comments
Closed

Network connectivity channels #347

ghost opened this issue Dec 9, 2016 · 2 comments

Comments

@ghost
Copy link

ghost commented Dec 9, 2016

I'vent checked lisk source code, but it seems it's working on normal http requests, wouldn't it be better to implement network connectivity additionally over websockets? Additionally limit connected peers to 15-25 per node, so network would be able to propagate data much, much faster and more reliably. Current propagation times are not good (many blocks are propagated in 1-2s, while IMO it should be less than 1s, possibly for most of network participants should be around or less 500ms.

I have also noticed that most nodes are usually "connected" to 100 or more peers, how it's being calculated ? If it's not websocket connection, then technically it can't be understood as connected, but maybe more like was connected in last N seconds?

@4miners
Copy link
Contributor

4miners commented Dec 15, 2016

That "connected" status is based on last request to that peer - if it was successfull (and peer replied properly with valid data) or not.

@karmacoma
Copy link
Contributor

Thanks @karek314. We will now handle this issue here: #409.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants