Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display both compressed and uncompressed diffs in report #46

Closed
rpiaggio opened this issue Sep 21, 2021 · 2 comments
Closed

Display both compressed and uncompressed diffs in report #46

rpiaggio opened this issue Sep 21, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@rpiaggio
Copy link

rpiaggio commented Sep 21, 2021

Alternatively, the ability to use an alternate config file from the GH action. Then, we could run bundlemon twice, one with compression and one without.

@rpiaggio rpiaggio added the enhancement New feature or request label Sep 21, 2021
@LironEr
Copy link
Owner

LironEr commented Sep 26, 2021

I started to work on monorepo support, which should solve this issue, I will also think about presenting compressed and uncompressed sizes.

I will update you on the progress.

@LironEr LironEr linked a pull request Dec 17, 2021 that will close this issue
@LironEr LironEr removed a link to a pull request Dec 17, 2021
@LironEr
Copy link
Owner

LironEr commented Dec 18, 2021

@rpiaggio sorry for the long wait

I decided not to solve this issue by displaying both compressed and uncompressed because this change would require a lot of changes to the current code and might make things more difficult, will try to think about that in the feature.

So the other solution is to use the "subproject" feature which is available in v1.3.0

yarn run bundlemon # assuming you are using default compression as gzip in your config file
yarn run bundlemon --subProject no-compression --defaultCompression none

or

yarn run bundlemon --subProject gzip-compression --defaultCompression gzip
yarn run bundlemon --subProject no-compression --defaultCompression none

Assuming you set Github output with comment & status this will create 2 comments and 2 statuses, one for each subproject.

Hope this solves the issue, if it does please close the issue,if not please let me know what I can do to help you (:

@LironEr LironEr pinned this issue Jan 23, 2022
@LironEr LironEr closed this as completed Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants