Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align frequency nomenclature between methods #554

Closed
2 tasks done
CommonClimate opened this issue May 31, 2024 · 1 comment
Closed
2 tasks done

Align frequency nomenclature between methods #554

CommonClimate opened this issue May 31, 2024 · 1 comment
Assignees
@CommonClimate

Comments

@CommonClimate
Copy link
Collaborator

CommonClimate commented May 31, 2024 •
edited
Loading

Series.Spectral() now has a freq argument that allows to pass either a string for the method or an array of frequencies.

Series.wavelet() and Series.wavelet_coherence() still use freq_method.

  • Behavior should be aligned
  • Do the same for MultipleSeries.spectral()
@CommonClimate CommonClimate self-assigned this May 31, 2024
@CommonClimate CommonClimate mentioned this issue Jun 18, 2024
Merged
@CommonClimate
Copy link
Collaborator Author

addressed by #580

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CommonClimate CommonClimate

Labels
None yet
Projects
Summer 2024 Pyleoclim Hackathon
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CommonClimate