Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add base services compose file #452

Merged
merged 7 commits into from
Nov 27, 2024
Merged

Conversation

walkah
Copy link
Collaborator

@walkah walkah commented Nov 25, 2024

Summary

This PR simplifies local development by gathering all of the supported (3rd party) services in a single docker compose file (docker/docker-compose.base.yml):

  • adds ./stack compose-services to run base services (still use ./stack compose-init to initialize the chain data)
  • removes ./stack commands for chain, ipfs, bacalhau
  • updates docker-compose.dev.yml to include docker-compose.base.yml
  • adds postgres to the stack (for upcoming solver work)
  • updates LOCAL_DEVELOPMENT.md with modified instructions

@walkah walkah requested a review from a team as a code owner November 25, 2024 21:50
@walkah walkah self-assigned this Nov 26, 2024
@walkah
Copy link
Collaborator Author

walkah commented Nov 26, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Nov 26, 2024
Copy link

cla-bot bot commented Nov 26, 2024

The cla-bot has been summoned, and re-checked this pull request!

LOCAL_DEVELOPMENT.md Outdated Show resolved Hide resolved
stack Show resolved Hide resolved
./stack chain
# then in another terminal
./stack chain-boot
./stack compose-init # This will clean the chain and boot it
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running compose-init a second time after running the base services, the following error is reported:

Error response from daemon: remove lilypad_chain-data: volume is in use - [440d450180a1295ee4d50c1f79e37f565d761cc59e9ff2de5f1f2b3e522c5685]

Everything runs fine starting the base services a second time without running compose-init a second time, but should this command give us a clean slate? (Not necessary on the PR, this does what we need for this PR.)

Copy link
Contributor

@bgins bgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out, works well! ✨

Left a couple questions and have one more. Should compose-up be updated to run compose-services? Or maybe update the "Using Docker Compose" section in LOCAL_DEVELOPMENT to request users run compose-services?

@bgins
Copy link
Contributor

bgins commented Nov 26, 2024

Tested it out, works well! ✨

Left a couple questions and have one more. Should compose-up be updated to run compose-services? Or maybe update the "Using Docker Compose" section in LOCAL_DEVELOPMENT to request users run compose-services?

Ah I see what I was missing. We include the base services here:

include:
- docker/docker-compose.base.yml

@walkah walkah merged commit 86a3bc6 into main Nov 27, 2024
4 checks passed
@walkah walkah deleted the walkah/feat-compose-services branch November 27, 2024 02:36
walkah added a commit that referenced this pull request Dec 10, 2024
* feat: add base services compose file

* fix: need same name

* fix: why r u sleeping?

* fix: rename default db

* fix: renumber docs

* fix: include
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants