-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add base services compose file #452
Conversation
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
./stack chain | ||
# then in another terminal | ||
./stack chain-boot | ||
./stack compose-init # This will clean the chain and boot it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running compose-init
a second time after running the base services, the following error is reported:
Error response from daemon: remove lilypad_chain-data: volume is in use - [440d450180a1295ee4d50c1f79e37f565d761cc59e9ff2de5f1f2b3e522c5685]
Everything runs fine starting the base services a second time without running compose-init
a second time, but should this command give us a clean slate? (Not necessary on the PR, this does what we need for this PR.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it out, works well! ✨
Left a couple questions and have one more. Should compose-up
be updated to run compose-services
? Or maybe update the "Using Docker Compose" section in LOCAL_DEVELOPMENT
to request users run compose-services
?
Ah I see what I was missing. We include the base services here: lilypad/docker/docker-compose.dev.yml Lines 2 to 3 in 1558133
|
* feat: add base services compose file * fix: need same name * fix: why r u sleeping? * fix: rename default db * fix: renumber docs * fix: include
Summary
This PR simplifies local development by gathering all of the supported (3rd party) services in a single docker compose file (
docker/docker-compose.base.yml
):./stack compose-services
to run base services (still use./stack compose-init
to initialize the chain data)./stack
commands for chain, ipfs, bacalhaudocker-compose.dev.yml
to includedocker-compose.base.yml