-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: run bacalhau in a separate container #438
Conversation
@@ -208,7 +208,7 @@ func (executor *BacalhauExecutor) getJobID( | |||
outputError := strings.Join(strings.Fields(strings.Join(splitOutputs[1:], " ")), " ") | |||
|
|||
if outputError != "" { | |||
return "", fmt.Errorf("error running command %s -> %s, %s", deal.ID, outputError, runOutput) | |||
log.Error().Msgf("error parsing output %s -> %s, %s", deal.ID, outputError, runOutput) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log.Error().Msgf("error parsing output %s -> %s, %s", deal.ID, outputError, runOutput) | |
log.Error().Msgf("error found while parsing output %s -> %s, %s", deal.ID, outputError, runOutput) |
Possible edit. It's not a parsing error, but an error we found while parsing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have thoughts about it being ERR
vs WARN
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tough call. On the one hand, the possible error we know about (around the version check) is more of a warning. On the other hand, could there be other errors that aren't a warning?
I'd say let's go with the common case we know about and use WARN
. If we start seeing other errors, we can revisit, but this may not matter once we have upgraded to the latest Bacalhau.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, once we get fully over to the bacalhau http api, a lot of this code become moot. 👍
Wondering if we may want to update the solver Line 14 in fe48d8c
lilypad/docker/solver/Dockerfile Line 25 in fe48d8c
lilypad/hardhat/scripts/print-l2-config.ts Lines 40 to 41 in fe48d8c
Line 237 in fe48d8c
Outside of the code, we would need to update:
|
My thinking (and I can be convinced otherwise) was that just in local dev / CI there's potential for port conflicts with kubo on |
Yeah, that makes sense! Let's go with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Integration tests and jobs running over here with the new setup. ✨
* fix: run bacalhau ins a separate container * chore: bump kubo version * new port for rate limit test * don't try to call API during tests * fix errors
Summary
Previously, we bundled bacalhau and lilypad in a single container for resource providers. This meant that any crash/exit from lilypad would restart both bacalhau and lilypad. This could create lots of phone-home version checks for bacalhau. This PR also:
HEALTHCHECK
to the bacalhau Dockerfile so that we can properly wait for it to boot before starting the RPTask/Issue reference
Closes: https://github.com/Lilypad-Tech/internal/issues/339
Test plan
docker-compose.dev.yaml
).docker-compose.yaml
file and try to run. You should still be able to run jobs.