Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/ci: limit waved failed model loading #2895

Merged
merged 5 commits into from
Jan 7, 2025
Merged

tests/ci: limit waved failed model loading #2895

merged 5 commits into from
Jan 7, 2025

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 6, 2025

What does this PR do?

part of #2888 to limit when we allow test failing due to connection issue
These actual stings also waved some real problems with loading models
plus some more different fixes
Before:

 % python .github/assistant.py changed-domains 2895
unittests/_helpers

After:

% python .github/assistant.py changed-domains 2895
unittests
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2895.org.readthedocs.build/en/2895/

.github/workflows/ci-tests.yml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69%. Comparing base (f7235c9) to head (e61b291).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2895   +/-   ##
======================================
  Coverage      69%     69%           
======================================
  Files         346     346           
  Lines       19142   19142           
======================================
  Hits        13230   13230           
  Misses       5912    5912           

@Borda Borda added the bug / fix Something isn't working label Jan 7, 2025
@Borda Borda merged commit 0b67927 into master Jan 7, 2025
48 of 57 checks passed
@Borda Borda deleted the ci/skips branch January 7, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant