Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: mecab-ko from fork for py3.12 testing #2794

Closed
wants to merge 5 commits into from
Closed

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 21, 2024

What does this PR do?

using fix in NoUnique/pymecab-ko#9 to enable full testing with py3.12

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2794.org.readthedocs.build/en/2794/

@Borda Borda requested a review from ethanwharris as a code owner October 21, 2024 21:21
@Borda Borda added the test / CI testing or CI label Oct 21, 2024
@Borda
Copy link
Member Author

Borda commented Oct 21, 2024

Building wheels for collected packages: mecab-ko
  Building wheel for mecab-ko (setup.py) ... error
  error: subprocess-exited-with-error
  
  × python setup.py bdist_wheel did not run successfully.
  │ exit code: 1
  ╰─> [25 lines of output]
      /Users/jirka/Workspace/torchmetrics/.venv/lib/python3.10/site-packages/setuptools/__init__.py:80: _DeprecatedInstaller: setuptools.installer and fetch_build_eggs are deprecated.
      !!
      
              ********************************************************************************
              Requirements should be satisfied by a PEP 517 installer.
              If you are using pip, you can try `pip install --use-pep517`.
              ********************************************************************************
      
      !!
        dist.fetch_build_eggs(dist.setup_requires)
      WARNING setuptools_scm.pyproject_reading toml section missing 'pyproject.toml does not contain a tool.setuptools_scm section'
      Traceback (most recent call last):
        File "/private/var/folders/vl/1yxwpkwn40j_ycd2zpxhfwm40000gn/T/pip-req-build-e6pi810g/.eggs/setuptools_scm-8.1.0-py3.10.egg/setuptools_scm/_integration/pyproject_reading.py", line 36, in read_pyproject
          section = defn.get("tool", {})[tool_name]
      KeyError: 'setuptools_scm'
      running bdist_wheel
      running build
      running build_py
      creating build
      creating build/lib.macosx-14-arm64-cpython-310
      creating build/lib.macosx-14-arm64-cpython-310/mecab_ko
      copying src/mecab_ko/__init__.py -> build/lib.macosx-14-arm64-cpython-310/mecab_ko
      copying src/mecab_ko/cli.py -> build/lib.macosx-14-arm64-cpython-310/mecab_ko
      running build_ext
      error: [Errno 2] No such file or directory: 'mecab-config'
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for mecab-ko
  Running setup.py clean for mecab-ko
Failed to build mecab-ko
ERROR: Could not build wheels for mecab-ko, which is required to install pyproject.toml-based projects

@Borda Borda marked this pull request as draft October 21, 2024 22:15
@Borda Borda closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant