Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support stepping options for lr scheduler #945

Closed
williamFalcon opened this issue Feb 25, 2020 · 1 comment · Fixed by #941
Closed

Support stepping options for lr scheduler #945

williamFalcon opened this issue Feb 25, 2020 · 1 comment · Fixed by #941
Labels
feature Is an improvement or enhancement
Milestone

Comments

@williamFalcon
Copy link
Contributor

williamFalcon commented Feb 25, 2020

Currently schedulers get called every epoch. Sometimes though, we want them to be called every step.

Proposal 1:
Allow configure_optimizers to return this:

return Adam, {'scheduler': LRScheduler, 'interval': 'batch|epoch'}

@ethanwharris @Borda thoughts? any simpler more general way of doing this? i think this dict can eventually have more options if we need to.

@srush

@williamFalcon williamFalcon added feature Is an improvement or enhancement help wanted Open to be worked on labels Feb 25, 2020
@williamFalcon williamFalcon added this to the 0.6.1 milestone Feb 25, 2020
@Borda
Copy link
Member

Borda commented Feb 25, 2020

@SkafteNicki is working on it... Thx!

@Borda Borda removed the help wanted Open to be worked on label Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants