Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected dataloader_idx_X added after log_dict. #6091

Closed
george-gca opened this issue Feb 19, 2021 · 1 comment · Fixed by #6274
Closed

Unexpected dataloader_idx_X added after log_dict. #6091

george-gca opened this issue Feb 19, 2021 · 1 comment · Fixed by #6274
Assignees
Labels
bug Something isn't working help wanted Open to be worked on logging Related to the `LoggerConnector` and `log()` priority: 1 Medium priority task
Milestone

Comments

@george-gca
Copy link
Contributor

🐛 Bug

Trainer is adding dataloader_idx_X to metrics, but it is not supposed to since the name of my metrics are data1/x and data2/x. It currently displays as data1/x/dataloader_idx_0=3.46e-14, data2/x/dataloader_idx_1=3.49e-14 in progress bar.

To Reproduce

https://colab.research.google.com/drive/1L_0LOl7pUeL7bzh6uZiRa3-WXYQQwirN?usp=sharing

Expected behavior

It should appear in progress bar the information as data1/x=3.46e-14, data2/x=3.49e-14 and ModelCheckpoint should find data1/x to save based on it.

Environment

  • CUDA:
    • GPU:
      • Tesla T4
    • available: True
    • version: 10.1
  • Packages:
    • numpy: 1.19.5
    • pyTorch_debug: True
    • pyTorch_version: 1.7.0+cu101
    • pytorch-lightning: 1.2.0
    • tqdm: 4.41.1
  • System:
    • OS: Linux
    • architecture:
      • 64bit
    • processor: x86_64
    • python: 3.6.9
    • version: Proposal for help #1 SMP Thu Jul 23 08:00:38 PDT 2020

Additional context

This was not happening before (I was using another version, but recently updated my pytorch lightning docker container), so I don't have working version information.

@george-gca george-gca added bug Something isn't working help wanted Open to be worked on labels Feb 19, 2021
@Borda Borda added logging Related to the `LoggerConnector` and `log()` priority: 1 Medium priority task labels Feb 20, 2021
@Borda Borda added this to the 1.2.x milestone Feb 20, 2021
@george-gca
Copy link
Contributor Author

Looking for it in older versions, I just realized this bug always existed, it was me that was not logging the metrics for the progress bar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Open to be worked on logging Related to the `LoggerConnector` and `log()` priority: 1 Medium priority task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants