Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keeping DP override in sync with upstream torch #5506

Closed
awaelchli opened this issue Jan 13, 2021 · 0 comments
Closed

Keeping DP override in sync with upstream torch #5506

awaelchli opened this issue Jan 13, 2021 · 0 comments
Assignees
@awaelchli
Labels
feature Is an improvement or enhancement refactor
Milestone
pl:1.2

Comments

@awaelchli
Copy link
Contributor

awaelchli commented Jan 13, 2021 •
edited
Loading

Same as in #4630, we want to redirect forward to the training_step, validaion_step, test_step methods but without having to copy the DP implementation directly from pytorch codebase. This would also allow users to easily override DP in Lightning.

See refactor for DDP here: #5185
@awaelchli awaelchli added feature Is an improvement or enhancement refactor labels Jan 13, 2021
@awaelchli awaelchli self-assigned this Jan 13, 2021
@awaelchli awaelchli added this to the 1.2 milestone Jan 13, 2021
@awaelchli awaelchli mentioned this issue Jan 27, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@awaelchli awaelchli

Labels
feature Is an improvement or enhancement refactor
Projects
None yet
Milestone
pl:1.2
Development

No branches or pull requests
1 participant
@awaelchli