Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new checkpoint_artifact_path_prefix argument MLFlowLogger to customize artifact path for model checkpoints #20540

Open
benglewis opened this issue Jan 9, 2025 · 1 comment · May be fixed by #20538
Open

Add new checkpoint_artifact_path_prefix argument MLFlowLogger to customize artifact path for model checkpoints #20540

benglewis opened this issue Jan 9, 2025 · 1 comment · May be fixed by #20538
Labels
feature Is an improvement or enhancement

Comments

@benglewis
Copy link

benglewis commented Jan 9, 2025 •
edited by github-actions bot
Loading

Description & Motivation

See #19394 (comment)
PyTorch Lightning's MLFlowLogger changed its behavior and there are things that are inconvenient about the current implementation.

Pitch

I have opened a PR to fix this as per above.

Alternatives

No response

Additional context

No response

cc @lantiga @Borda
@benglewis benglewis added feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers labels Jan 9, 2025
@benglewis benglewis linked a pull request Jan 9, 2025 that will close this issue
Open
10 tasks
@lantiga
Copy link
Collaborator

lantiga commented Jan 13, 2025

Thank you for raising the issue @benglewis, in retrospect it was a breaking change.

Do you think we should make the default behavior go back to what it was, with the new added flexibility?

@lantiga lantiga removed the needs triage Waiting to be triaged by maintainers label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Is an improvement or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add checkpoint artifact path prefix to MLflow logger benglewis/pytorch-lightning
2 participants
@lantiga @benglewis