Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _call_accelerator_hook after move accelerator into strategy #10905

Closed
four4fish opened this issue Dec 2, 2021 · 0 comments · Fixed by #10999
Closed

Remove _call_accelerator_hook after move accelerator into strategy #10905

four4fish opened this issue Dec 2, 2021 · 0 comments · Fixed by #10999

Comments

@four4fish
Copy link
Contributor

four4fish commented Dec 2, 2021

Proposed refactor

From discussion in #10575

Motivation

Pitch

rename the _call_ttp_hook to _call_strategy_hook once the rename is formalized, and remove this _call_accelerator_hook entirely

Part of the #10648

Additional context


If you enjoy Lightning, check out our other projects! ⚡

  • Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

  • Lite: enables pure PyTorch users to scale their existing code on any kind of device while retaining full control over their own loops and optimization logic.

  • Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, fine-tuning, and solving problems with deep learning.

  • Bolts: Pretrained SOTA Deep Learning models, callbacks, and more for research and production with PyTorch Lightning and PyTorch.

  • Lightning Transformers: Flexible interface for high-performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.

cc @justusschock @awaelchli @akihironitta @kaushikb11 @ananthsub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants