Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: add SSIM #2671

Merged
merged 3 commits into from
Jul 23, 2020
Merged

metrics: add SSIM #2671

merged 3 commits into from
Jul 23, 2020

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Jul 22, 2020

What does this PR do?

Fixes #1300

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team July 22, 2020 10:52
@codecov
Copy link

codecov bot commented Jul 22, 2020 •
edited
Loading

Codecov Report

Merging #2671 into master will increase coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #2671    +/-   ##
=======================================
+ Coverage      87%     91%    +4%     
=======================================
  Files          74      74            
  Lines        6187    6241    +54     
=======================================
+ Hits         5392    5709   +317     
+ Misses        795     532   -263

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Jul 22, 2020

It's ready to review.

@mergify mergify bot requested a review from a team July 22, 2020 11:42
@Borda Borda added the feature Is an improvement or enhancement label Jul 22, 2020
@Borda Borda added this to the 0.8.x milestone Jul 22, 2020
@mergify
Copy link
Contributor

mergify bot commented Jul 22, 2020

This pull request is now in conflict... :(

@mergify mergify bot requested a review from a team July 22, 2020 16:53
@Borda Borda requested review from justusschock and removed request for a team July 22, 2020 16:53
@mergify mergify bot requested a review from a team July 22, 2020 16:53
ydcjeff added 3 commits July 22, 2020 23:56
metrics: add SSIM
ae2f7ef
Update CHANGELOG.md
1333ab9 
fix codefactor issue

fix doctest

fix doctest

fix test
added test for raise Error
d8cef30
@ydcjeff
Copy link
Contributor Author

ydcjeff commented Jul 22, 2020 •
edited
Loading

Finally, I can properly and clearly rebase 😆😆

@williamFalcon williamFalcon merged commit bda7cf1 into Lightning-AI:master Jul 23, 2020
@ydcjeff ydcjeff deleted the metrics/add-ssim branch July 23, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@SkafteNicki SkafteNicki Awaiting requested review from SkafteNicki

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees
No one assigned
Labels
feature Is an improvement or enhancement
Projects
None yet
Milestone
pl:0.8.x
Development

Successfully merging this pull request may close these issues.

[Metrics] SSIM
4 participants
@ydcjeff @awaelchli @Borda @williamFalcon