-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Add log_weight_decay
argument to LearningRateMonitor
callback
#18439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
awaelchli
merged 13 commits into
Lightning-AI:master
from
ioangatop:ioannis@add-log_weight_decay-option-to-LearningRateMonitor-callback
Sep 5, 2023
Merged
Add log_weight_decay
argument to LearningRateMonitor
callback
#18439
awaelchli
merged 13 commits into
Lightning-AI:master
from
ioangatop:ioannis@add-log_weight_decay-option-to-LearningRateMonitor-callback
Sep 5, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #18439 +/- ##
==========================================
- Coverage 85% 50% -35%
==========================================
Files 427 419 -8
Lines 33277 33143 -134
==========================================
- Hits 28285 16613 -11672
- Misses 4992 16530 +11538 |
awaelchli
approved these changes
Aug 31, 2023
…tor-callback' of https://github.com/ioangatop/pytorch-lightning into ioannis@add-log_weight_decay-option-to-LearningRateMonitor-callback
…rningRateMonitor-callback
carmocca
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
…rningRateMonitor-callback
…rningRateMonitor-callback
…rningRateMonitor-callback
…rningRateMonitor-callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
callback: lr monitor
community
This PR is from the community
feature
Is an improvement or enhancement
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #18117
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist