-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to overwrite the existing checkpoint file #17320
Merged
carmocca
merged 14 commits into
Lightning-AI:master
from
solyaH:feature/override_checkpoint_file
May 3, 2023
Merged
Add an option to overwrite the existing checkpoint file #17320
carmocca
merged 14 commits into
Lightning-AI:master
from
solyaH:feature/override_checkpoint_file
May 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
solyaH
requested review from
awaelchli,
carmocca,
justusschock and
williamFalcon
as code owners
April 10, 2023 17:36
awaelchli
added
feature
Is an improvement or enhancement
callback: model checkpoint
community
This PR is from the community
labels
Apr 11, 2023
awaelchli
reviewed
Apr 11, 2023
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Borda
approved these changes
Apr 14, 2023
carmocca
reviewed
Apr 28, 2023
carmocca
reviewed
May 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a CHANGELOG.md entry, please?
carmocca
reviewed
May 3, 2023
carmocca
approved these changes
May 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
May 3, 2023
Borda
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
callback: model checkpoint
community
This PR is from the community
feature
Is an improvement or enhancement
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If you want to preserve the checkpoint's file name, you can now specify
override_existing=True
on the ModelCheckpoint constructor. It will lead to overwriting the file path instead of writing a new file with the version appended.Fixes #15106
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist