-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use kl_coeff in loss function calculation #330
Conversation
remove unnecessary kl_coeff argument
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
==========================================
+ Coverage 82.18% 82.24% +0.05%
==========================================
Files 98 98
Lines 5491 5492 +1
==========================================
+ Hits 4513 4517 +4
+ Misses 978 975 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for the swift action!
My pleasure! Excuse the weird question, but would you be able to give me an estimate of when this will be included in a minor release? Thanks! :) |
we'll have a release as soon as we are done with simclr fixes, which should be a couple of days max. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
The VAE model contained here takes an optional
kl_coeff
parameter that's supposed to be a scaling factor for the KL term of the variational loss. This might be useful to avoid the "posterior collapse phenomenon". This pull request makes sure that it's used in the loss function.Fixes #328.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Absolutely! =)