-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confused logit callback #118
Conversation
williamFalcon
commented
Jul 15, 2020
Hello @williamFalcon! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-07-31 12:42:27 UTC |
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
==========================================
- Coverage 92.25% 91.42% -0.84%
==========================================
Files 79 82 +3
Lines 4031 4057 +26
==========================================
- Hits 3719 3709 -10
- Misses 312 348 +36
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
||
mask_idx = mask_idxs[img_i] | ||
|
||
fig = plt.figure(figsize=(15, 10)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use rather fig, axarr = plt.subplots(ncol=3, nrow=2)
and alter you just axarr[1, 2].imshow(...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't have a lot of time to mess with this. i don't know if this will work, but i know the current version works.
If you feel strongly about it, mind making the changes and posting a colab that shows this works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I ll check I because the call to plt.
takes the last pointer and if you plot two in parallel you will write everything into one