Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aborting a job leads to an unlimited amount of toast-popups about its completion #547

Closed
1 of 2 tasks
RubenKelevra opened this issue Jul 15, 2022 · 4 comments
Closed
1 of 2 tasks
Labels
bug Something isn't working

Comments

@RubenKelevra
Copy link

RubenKelevra commented Jul 15, 2022

🐛 Bug Report

  • I am including my log files in zip format.
  • I have looked for similar issues among all the former issues including closed ones.

What Operating system and version is LibrePhotos running on:

Arch Linux

What architecture is LibrePhotos running on:

x64

How is LibrePhotos installed:

Docker

If running via Docker or Kubernetes please list version including docker-compose:

2.6.1

How is you picture library mounted on the host (or in the virtual machine):

Local file system (ZFS)

Description of issue:

I started a scan of newly added pictures. While it was undergoing I've added additional pictures, that's why I wanted to restart the task.

So I went to the admin panel and stopped it.

Then there's a toast popup like once a second about completion of this task (which sounds more like a success message btw) repeatedly, until I reload the page.

How can we reproduce it:

See above


I've seen the help text stating that the "remove" isn't going to stop the task - but the task gets shown as aborted in the view afterwards... mh.

Screenshot_20220715_130913-1

@RubenKelevra RubenKelevra added the bug Something isn't working label Jul 15, 2022
@meichthys
Copy link
Contributor

This is also applicable to scans that finish successfully: #536

@polaroidkidd
Copy link

polaroidkidd commented Jul 25, 2022

whoops, yes. That probably has something to do with this line here /src/hooks/useWorkerStatus.ts#L28

I think I'll have to add a case where it handles canceled jobs there.

@derneuere
Copy link
Member

@polaroidkidd This should be fixed now with the new RTK queries, right?

@polaroidkidd
Copy link

no. I actually just found out that the "finished" notifications are a bit broken. Are jobs asynchronous in the backend? is there a que they enter? do they exit FIFO wise or "which ever job finnishes first" and a round-robbin of sorts jumps back and forth between jobs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants