Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use autoDestroy when it lands in readable-stream (node 11.2.0) #13

Closed
vweevers opened this issue Apr 22, 2019 · 0 comments
Closed

Use autoDestroy when it lands in readable-stream (node 11.2.0) #13

vweevers opened this issue Apr 22, 2019 · 0 comments
Labels
refactor Requires or pertains to refactoring semver-patch Bug fixes that are backward compatible

Comments

@vweevers
Copy link
Member

See autoDestroy:

Whether this stream should automatically call .destroy() on itself after ending.

I think that can replace:

https://github.com/Level/iterator-stream/blob/d59b13a9ef3ae7862c7a8e9262d7d7c417e067df/index.js#L16
@vweevers vweevers added semver-patch Bug fixes that are backward compatible refactor Requires or pertains to refactoring labels Apr 22, 2019
@vweevers vweevers changed the title Use autoDestroy instead of on('end', this.destroy) Use autoDestroy when it lands in readable-stream (node 11.2.0) Apr 22, 2019
@vweevers vweevers transferred this issue from Level/iterator-stream Nov 19, 2022
@vweevers vweevers moved this from Backlog to Todo in Level Jan 31, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Level Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Requires or pertains to refactoring semver-patch Bug fixes that are backward compatible
Projects
Level
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vweevers