Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility issue #1

Closed
emmarichardson opened this issue Feb 28, 2024 · 15 comments
Closed

Accessibility issue #1

emmarichardson opened this issue Feb 28, 2024 · 15 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@emmarichardson
Copy link

I am receiving an error on an accessibility scan that the form is missing a label - the error is pointing to this in the html.

@emmarichardson
Copy link
Author

For some reason, the code I pasted above did not stick. The label that is needed is to show that the form should not pull from autocomplete - so it is needing an aria label for the input box.
In addition, accessibility is complaining about lack of contrast with the form box. The border is too light.

@emmarichardson
Copy link
Author

Here is a screenshot with the contrast issue - I think the form labelling is not needed - as I read more that was in case it should have an autofill which it should not.
Screenshot 2024-03-20 at 8 01 00 AM

@gemguardian
Copy link
Member

@luukverhoeven could you please put this on your calendar to check how much time is needed to fix it.

@luukverhoeven
Copy link
Collaborator

@vincentcornelis Can you check this? Thanks

@vincentcornelis
Copy link
Collaborator

Hi @emmarichardson

What Moodle version are you receiving this accessibility issue for?
Are you using theme Boost, or another theme?

Correct me if i'm wrong, but this issue would be regarding the following element?:

<input ... name="efquicklistsearch">...</input>

Default display of this element has the text-input as white on white with a dark-gray border, which when focussed gives the additional blue outline, which should provide a contrast of 3.02 for the gray, (which, i realise, would still not reach the aforementioned 3.1 contrast. However, we don't apply additional styling, this is the case for all default Moodle form elements), and a contrast of 3.36 for the blue.

image

image

Moodle 4.2:

image
image

Moodle 3.11:

image
image

I am however unable to discover a place where the contrast is the 1.49:1 you mentioned.

Like to hear back from you!

@luukverhoeven
Copy link
Collaborator

@gemguardian @emmarichardson Do you have an update on this?

@gemguardian
Copy link
Member

@luukverhoeven as it seems we cannot replicate this issue, or received other remarks on it. I tend to close this issue as 'won't fix'. @emmarichardson if you have time to reply we dan take a nother look at it.

@emmarichardson
Copy link
Author

Sorry for lack of response. I ended up using css to get around the contrast issue. Using Foundation as theme. I still receive the complaint about the lack of label for aria but have yet to determine if that is an actual issue because it is expecting a label for autofill which is not appropriate.

@gemguardian
Copy link
Member

@emmarichardson thank you for your response, since we use the stying of Moodle Boost form, and don't 'override' the styling, this sounds as something you could make a Moodle tracker of so that moodle pty ltd is aware of this accessibility issue.

as for the lack of label aria, I checked the wcag 1.2 guidelines and I do think we can assist in this - but we only deploy it for the latest master/main branche.

@luukverhoeven I would suggest the Aria Seach because it is a search form https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/searchbox_role or - following the fact we use form - we could use the aria form : https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/form_role

Could you please let me know what you think and the time invested to fix for the main /master branche?

@luukverhoeven
Copy link
Collaborator

@gemguardian We estimate that it will take 1 or 2 hours to develop and test this.

@gemguardian
Copy link
Member

@luukverhoeven This is approved but for the latest main branche version, we don't backport this issue.

@luukverhoeven
Copy link
Collaborator

@gemguardian
Copy link
Member

@luukverhoeven I can confirm that we see a aria-label "Search for courses" in M4.4

image

@gemguardian
Copy link
Member

@luukverhoeven could yuo please this to the master and release it on Moodle.org - Could you please check Moodle.org branches as well, I doubt that this is the same line as we use Github.

  • Gemma

@gemguardian gemguardian removed their assignment Jul 17, 2024
@luukverhoeven
Copy link
Collaborator

@gemguardian Merged and published on Moodle.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants