Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have you considered integrating vue-format directly into atom-beautify? #1

Open
PaulCapestany opened this issue Jan 5, 2016 · 8 comments

Comments

@PaulCapestany
Copy link

First off, just wanted to say thanks for putting this together! I've found it very useful :)

Just wondering if you'd thought about perhaps submitting a PR to https://github.com/Glavin001/atom-beautify to have vue-format work alongside all the other formatters?

There's actually already an open issue about Vue formatting on the beautify repo → Glavin001/atom-beautify#722

@LeslieYQ
Copy link
Owner

LeslieYQ commented Jan 6, 2016

I'll be glad to submit this �to atom-beautify, but i don't know how to do?

I am currently focused on https://github.com/LeslieYQ/vue-pagination

If you are interested, we can get together.

sorry about reply you later,it's too busy。

@PaulCapestany
Copy link
Author

Hopefully I'm not misunderstanding, but to integrate the projects you would need to fork the atom-beautify code, add in your vue-format work, and then submit a pull request.

I've been busy too, so no worries!

@PaulCapestany
Copy link
Author

There's also documentation on how to add an unsupported language to atom-beautify using an existing beautifier

@LeslieYQ
Copy link
Owner

LeslieYQ commented Jan 7, 2016

thank's, I'll try it next week.

Maybe,it's wrong with your Url about add an unsupported language

@PaulCapestany
Copy link
Author

Hey @LeslieYQ, I think if you edit an existing comment Github doesn't send a new notification, so I'm just now noticing your edit about me having the wrong URL. Oops. Here is the proper link → https://github.com/Glavin001/atom-beautify/wiki/Add-an-unsupported-language-using-an-existing-beautifier

@allentong
Copy link

Bumping this.

@Glavin001
Copy link

@LeslieYQ please let me know if there's anything I can do to help guide you through the process of integrating vue-format with Atom-Beautify. In the past, what I have recommended is that maintainers would publish an isolated package to npm that implements their beautifying/formatting functionality, and then a quick Pull Request to Atom-Beautify could be made. For example: vingorius/jade-beautify#7

@LeslieYQ
Copy link
Owner

thanks. I will do it as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants