Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end_date > start_date validation in harvest form #366

Open
2ynn opened this issue Sep 23, 2023 · 0 comments
Open

Add end_date > start_date validation in harvest form #366

2ynn opened this issue Sep 23, 2023 · 0 comments
Assignees

Comments

@2ynn
Copy link
Collaborator

2ynn commented Sep 23, 2023

Type of Issue: Feature request

Current behavior

harvest.end_date is used to determine whether a harvest is still open to registration or not.
However only the end time is being displayed on the public calendar and no validation insures end_date > start_date.
This can cause a lot of confusion if start date and end date don't happen to match and lead to volunteers not being able to register even though the harvest shows in yellow and in the future on the calendar. Additionally the end_date is not displayed on the harvest detail page, only in the form itself (i.e. harvests are assumed to last no longer than one day).

Suggested changes

Add form validation on end_date

Note: although it is safe to assume that regular picks typically happen the same day (i.e. a time picker could be used for selecting only the end time), the end date is useful in the case of fruit groups.

@2ynn 2ynn self-assigned this Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant