Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing removed posts showing. Fixes #2875 #3279

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

dessalines
Copy link
Member

@dessalines dessalines commented Jun 23, 2023

@dessalines dessalines requested a review from Nutomic as a code owner June 23, 2023 02:53
@kartikynwa
Copy link
Contributor

kartikynwa commented Jun 23, 2023

Needs one more clippy fix:

diff --git a/src/lib.rs b/src/lib.rs
index 86cf400b6..efcd67fd6 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -205,7 +205,7 @@ pub fn init_logging(opentelemetry_url: &Option<Url>) -> Result<(), LemmyError> {
     .trim_matches('"')
     .parse::<Targets>()?;

-  let format_layer = tracing_subscriber::fmt::layer().with_filter(targets.clone());
+  let format_layer = tracing_subscriber::fmt::layer().with_filter(targets);

   let subscriber = Registry::default()
     .with(format_layer)

Code changes look good.

@Nutomic
Copy link
Member

Nutomic commented Jun 23, 2023

I made a fix for the same issue in #3286 before noticing this one. Honestly I think my fix is better, so I copied the test case there.

@Nutomic Nutomic merged commit dce79b8 into main Jun 23, 2023
Nutomic pushed a commit that referenced this pull request Jun 26, 2023
* Fixing removed posts showing. Fixes #2875

* Fixing clippy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants